Opened 7 years ago

Last modified 7 years ago

#622 assigned enhancement

e4: review logging code

Reported by: Rene Ranzinger Owned by: Rene Ranzinger
Priority: normal Milestone: GRITS e4 migration
Component: GRITS core Version: GRITS 1.1.x
Severity: major Keywords:
Cc: shan

Description

The current logging code (log4j) uses 4 classes in the log package of which some are no longer needed. Take a look at the alternative implementation in dropbox (com.github.reneranzinger.fstools.core.rar).

It uses two methods in com.github.reneranzinger.fstools.core.lifecycle.LifeCycleManager:

  • configureLogFolder
  • configureLogger

and the com.github.reneranzinger.fstools.core.logging.FileSystemToolsLogAppender

We can use the core of the code for GRITS as well. In addition to simplifying the code it also has other advantages:

  • it uses a different log pattern, removing two of the time consuming parts of the old pattern
  • it will fix a bug causing GRITS to crash on startup (#621)

Change History (5)

comment:1 Changed 7 years ago by Rene Ranzinger

Owner: set to shan
Status: new → assigned

comment:2 Changed 7 years ago by shan

Status: assigned → accepted

comment:3 Changed 7 years ago by shan

Resolution: → fixed
Status: accepted → review

modified in revision [1338] of the svn

  • added a second option of choosing ${user.home}/.grits-toolbox/log/ if Platform.getConfigurationLocation() fails (for reasons like no write access)

comment:4 Changed 7 years ago by Rene Ranzinger

Resolution: fixed
Status: review → assigned

comment:5 Changed 7 years ago by Rene Ranzinger

Owner: changed from shan to Rene Ranzinger
Note: See TracTickets for help on using tickets.