#657 closed task (fixed)
Sample Manager : Clean/Optimize API classes for Sample Ontology
| Reported by: | shan | Owned by: | shan |
|---|---|---|---|
| Priority: | normal | Milestone: | GRITS - 1.2 |
| Component: | Sample management | Version: | GRITS 1.1.x |
| Severity: | major | Keywords: | |
| Cc: |
Description
Sample plugin and Sample Ontology Manager plugin share classes for reading and writing to ontology. Clean up/optimize the classes and separate them into two plugins.
Change History (8)
comment:1 Changed 6 years ago by
| Owner: | set to shan |
|---|---|
| Status: | new → assigned |
comment:2 Changed 6 years ago by
| Component: | GRITS core → Sample management |
|---|
comment:3 Changed 6 years ago by
| Status: | assigned → accepted |
|---|
comment:4 Changed 6 years ago by
| Milestone: | GRITS - 1.1 SR1 → GRITS - 1.1 SR2 |
|---|
comment:5 Changed 5 years ago by
| Milestone: | GRITS - 1.2 → GRITS - 1.2 SR1 |
|---|
comment:6 Changed 5 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | accepted → review |
comment:7 Changed 5 years ago by
| Status: | review → closed |
|---|
comment:8 Changed 5 years ago by
| Milestone: | GRITS - 1.2 SR1 → GRITS - 1.2 |
|---|
Note: See
TracTickets for help on using
tickets.
Ontology managers have been rewritten for Sample plugin. For Sample Manager plugin old classes have been moved to this plugin but a separate ticket should be created if needed to rewrite its ontology managers similar to sample plugin.
In sample plugin, manager has been separated into two layers and an interface. The interface enlists all available public methods with a clean overview and Javadoc. The top layer implements functionalities by using its lower layer to call low level APIs which directly interact with the ontologies. The lower layer also facilitates reuse of methods for interacting with the ontologies that would otherwise be rewritten in various methods in the upper layer.
If developers would use sample manager plugin APIs more frequently for editing sample ontology then it should be cleaned and rewritten similar to sample plugin. Rewriting the sample manager plugin in a similar way would make it easy for developers to use it and integrate it with their code but for now the current code works.