Opened 4 years ago

Closed 4 years ago

#779 closed defect (fixed)

Custom Annotation - Filter dialog

Reported by: Rene Ranzinger Owned by: dbrentw
Priority: normal Milestone: GRITS - 1.2
Component: MS data management Version: GRITS 1.1.x
Severity: major Keywords:
Cc: dbrentw

Description (last modified by Rene Ranzinger)

  • Use TitleAreaDialog as for other dialogs
  • Description field should be multiline text.
  • Mass tolerance should only allow positive numerical values
  • Tolerance Type should have PPM selected by default
  • Should not have the same name as main dialog
  • Enter a non-numerical value for m/z crashes the dialog without feedback
  • Non-numerical values for MS Level are accepted (should be only int > 1)
  • Columns in table should be sort-able
  • If a list is selected in the dropdown
    • Edit Selected => table is still disabled (can be fixed by mouse over)
    • Select other list => table is still enabled
  • for the file export use windows line breaks otherwise it will look like a single liner in Notepad
  • Double click in empty row will throw java.lang.IndexOutOfBoundsException

Change History (7)

comment:1 Changed 4 years ago by Rene Ranzinger

Component: GRITS coreMS data management
Owner: set to dbrentw
Status: newassigned

comment:2 Changed 4 years ago by Rene Ranzinger

Description: modified (diff)

comment:3 Changed 4 years ago by Rene Ranzinger

Description: modified (diff)

comment:4 Changed 4 years ago by Rene Ranzinger

Description: modified (diff)

comment:5 Changed 4 years ago by dbrentw

Status: assignedaccepted

comment:6 Changed 4 years ago by dbrentw

Resolution: fixed
Status: acceptedreview

Addressed in SVN revision 1730

I could not replicate the issue where the table remains editable after changing the dropdown. Perhaps this is resolved w/ the redraw of the table.

comment:7 Changed 4 years ago by Rene Ranzinger

Status: reviewclosed
Note: See TracTickets for help on using tickets.