Opened 3 years ago

Closed 3 years ago

#910 closed task (worksforme)

MS Merge: One sided interactive merge

Reported by: Rene Ranzinger Owned by: dbrentw
Priority: highest Milestone: GRITS - 1.2 SR1
Component: MS merge Version: GRITS 1.1.x
Severity: major Keywords:
Cc: dbrentw, sena

Description

In the merge report allow the user to pick a cell and open the corresponding MS annotation entry + scroll to peak. This can be used to quickly find annotation errors and correct them. It is currently not planned that the report gets updated based on these new selections. To get a merge report with the changes a new Merge entry must be created.

Change History (9)

comment:1 Changed 3 years ago by Rene Ranzinger

Owner: set to dbrentw
Status: newassigned

comment:2 Changed 3 years ago by dbrentw

Priority: normalhighest
Status: assignedaccepted

comment:3 Changed 3 years ago by dbrentw

OK, well, I went ahead and made it bi-directional. If the user double-clicks a row the table detects what experiment has been clicked (user clicks one of the columns under the experiment of interest). GRITS then opens the annotation views for that peak. Note that, at least in the first version, GRITS must open the Overview, followed by the Structure Annotation view, and then the Summary View. If selections change on the Summary view or the bottom table of the Structure Annotation view, then the Merge report updates. The GRITS report is marked as dirty. Saving the report will update the xml file.

Addressed in SVN revision 2358.

comment:4 Changed 3 years ago by dbrentw

Resolution: fixed
Status: acceptedreview

Changed the notification system to use the event broker. See SVN revision [2446]

comment:5 Changed 3 years ago by dbrentw

More changes in SVN revision [2458]

comment:6 Changed 3 years ago by dbrentw

More changes. Dynamic merge wasn't working for older merge reports. See SVN revision [2459]

comment:7 Changed 3 years ago by sena

Resolution: fixed
Status: reviewassigned

I've tried to double-click on a structure whose experiment is not currently open and got the following exception. The annotation table was never opened. It only fails for the second experiment in my case, the first experiment's structures open fine even if the annotation table is not previously opened.

java.lang.NullPointerException

at org.grits.toolbox.entry.ms.annotation.glycan.report.tablehelpers.MSGlycanAnnotationReportTable.mouseDoubleClick(MSGlycanAnnotationReportTable.java:651)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:197)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4256)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1501)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1524)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1509)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1313)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4080)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3706)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
at org.grits.toolbox.core.Application.start(Application.java:29)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
at org.eclipse.equinox.launcher.Main.main(Main.java:1492)

comment:8 Changed 3 years ago by sena

Resolution: worksforme
Status: assignedreview

Although I've seen it happening for my report, I cannot confirm that the problem exists for current reports. The workspace might have been in some incorrect state at the time. Reinitializing the workspace (from DemoWorkspace) fixed the issue.

comment:9 Changed 3 years ago by sena

Status: reviewclosed
Note: See TracTickets for help on using tickets.