Opened 4 years ago

Closed 3 years ago

#945 closed enhancement (fixed)

MS Editor: Multiple instance of non modal dialogs

Reported by: Rene Ranzinger Owned by: dbrentw
Priority: normal Milestone: GRITS - 1.2 SR1
Component: MS annotation management Version: GRITS 1.1.x
Severity: major Keywords:
Cc: sena, dbrentw


When using the toolbar or menu to open non modal dialogs:

  • Filter
  • Custom annotation

Its possible that the dialog disappears behind another windows. Clicking on the toolbar or menu again will open a second dialog of the same kind. That leads to confusion and partially incorrect values if the dialog get prefilled with the current state.

Change History (8)

comment:1 Changed 4 years ago by Rene Ranzinger

Owner: set to sena
Status: newassigned

comment:2 Changed 4 years ago by sena

Owner: changed from sena to dbrentw

I changed the filter dialog to be modal since it does not make much sense to keep it open and be able to do other things when it is open.
in revision [2235]

I am not sure though about the custom annotation dialog. I thought it is supposed to be modeless but if you click on the "custom annotation" menu again, it should not create a new dialog but use the existing open one if any. Brent would know the intensions better.

comment:3 Changed 3 years ago by dbrentw

Resolution: fixed
Status: assignedreview

Addressed in SVN revision [2522], [2532], [2533]

comment:4 Changed 3 years ago by sena

Resolution: fixed
Status: reviewassigned

Filter dialog is modal now.

Custom annotation dialog does stay on top but whenever the user clicks to open one from the menu, it opens a second, third custom annotation dialog although there was one already open.

comment:5 Changed 3 years ago by dbrentw

Status: assignedaccepted

comment:6 Changed 3 years ago by sena

Resolution: fixed
Status: acceptedreview

fixed in revision [2753]

comment:7 Changed 3 years ago by sena

tested with revision [2761]

comment:8 Changed 3 years ago by sena

Status: reviewclosed
Note: See TracTickets for help on using tickets.