Opened 3 years ago

Closed 2 years ago

#999 closed defect (fixed)

MS Summary View: clicking column header corrupts table

Reported by: sena Owned by: dbrentw
Priority: normal Milestone: GRITS - 1.2 SR2
Component: MS annotation management Version: GRITS 1.2.x
Severity: major Keywords:
Cc:

Description

In Summary View (for MS2) if you click the column header twice, the whole table disappears. The screenshot is attached.

Attachments (1)

Screen Shot 2017-09-13 at 3.34.40 PM.png (138.0 KB) - added by sena 3 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 3 years ago by sena

It looks like it only happens for MS3 level or when there is only one column (one candidate annotation)

comment:2 Changed 3 years ago by sena

here is the exception from the log:

java.lang.NullPointerException

at org.grits.toolbox.entry.ms.annotation.glycan.tablehelpers.MSGlycanAnnotationSummaryTable.toggleParentSelectedRow(MSGlycanAnnotationSummaryTable.java:608)
at org.grits.toolbox.entry.ms.annotation.glycan.tablehelpers.MSGlycanAnnotationSummaryTable.mouseDown(MSGlycanAnnotationSummaryTable.java:566)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:193)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4256)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1501)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1524)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1509)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1313)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4080)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3706)

Changed 3 years ago by sena

comment:3 Changed 2 years ago by dbrentw

Status: assignedaccepted

comment:4 Changed 2 years ago by Rene Ranzinger

Milestone: GRITS - 1.2 SR1GRITS - 1.2 SR2

comment:5 Changed 2 years ago by dbrentw

Resolved in SVN Revision [2784]

comment:6 Changed 2 years ago by dbrentw

Resolution: fixed
Status: acceptedreview

comment:7 Changed 2 years ago by sena

Resolution: fixed
Status: reviewassigned

corruption of table is fixed but there is still an exception in the log (and nothing happens) if you deselect the candidate by clicking on the checkbox at the header.

!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NullPointerException

at org.grits.toolbox.entry.ms.annotation.glycan.tablehelpers.MSGlycanAnnotationSummaryTable.toggleParentSelectedRow(MSGlycanAnnotationSummaryTable.java:612)
at org.grits.toolbox.entry.ms.annotation.glycan.tablehelpers.MSGlycanAnnotationSummaryTable.mouseDown(MSGlycanAnnotationSummaryTable.java:570)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:192)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4362)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1113)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4180)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3769)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)


comment:8 Changed 2 years ago by sena

Resolution: fixed
Status: assignedreview

should be fixed in revision [2869]

comment:9 Changed 2 years ago by sena

Resolution: fixed
Status: reviewassigned

I was able to reproduce "the clicking on the column header twice" problem. Opened demo workspace: NGlycans-C. Opened scan 8 and double click on scan 9 to open the details page. clicked the cartoon header twice and the whole table disappeared. There is no issue for a similar scan in NGlycans-A entry.

comment:10 Changed 2 years ago by dbrentw

Status: assignedaccepted

comment:11 Changed 2 years ago by dbrentw

Resolution: fixed
Status: acceptedreview

Fixed in SVN revision [2999]

comment:12 Changed 2 years ago by sena

Status: reviewclosed

confirmed for NGlycans-C

Note: See TracTickets for help on using tickets.